Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jupyter_client to dep to ensure it contains the needed fix #17

Merged
merged 1 commit into from
May 30, 2024
Merged

Add jupyter_client to dep to ensure it contains the needed fix #17

merged 1 commit into from
May 30, 2024
+2 −1

Conversation

fcollonval
Copy link
Member

No description provided.

@fcollonval fcollonval added the enhancement New feature or request label May 27, 2024
@github-actions GitHub Actions
Copy link

Binder 👈 Launch a Binder on branch datalayer/jupyter-server-nbmodel/fcollonval-patch-1

@fcollonval fcollonval requested a review from echarles May 30, 2024 13:24
echarles
echarles approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @fcollonval

@echarles echarles merged commit da00ed8 into main May 30, 2024
7 of 8 checks passed
@fcollonval fcollonval deleted the fcollonval-patch-1 branch July 12, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarles echarles echarles approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @echarles